src: Reset error struct if error code is napi_ok#40552
Closed
JckXia wants to merge 1 commit intonodejs:masterfrom
Closed
src: Reset error struct if error code is napi_ok#40552JckXia wants to merge 1 commit intonodejs:masterfrom
JckXia wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
jasnell
approved these changes
Oct 24, 2021
JckXia
force-pushed
the
reset-err-info-if-napi-ok
branch
from
61c473e to
2bdcfd5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
25 tasks
Collaborator
Collaborator
Collaborator
This was referenced Oct 27, 2021
gabrielschulhof
approved these changes
Oct 29, 2021
Collaborator
This was referenced Oct 30, 2021
Collaborator
This was referenced Nov 4, 2021
JckXia
force-pushed
the
reset-err-info-if-napi-ok
branch
from
2bdcfd5 to
ad97f6e
Compare
Member
Author
|
@mhdawson It looks like the CI has passed after a rebase. |
Collaborator
Member
|
@JckXia I needed to kick off a CI, the passing checks are the ones done through actions. A commend with the new CI should be added to the issue soon and lets keep our fingers crossed that it passes this time. |
40 tasks
Member
Author
|
@mhdawson Hmm it looks like the CI failed again. Will do more digging. |
juanarbol
approved these changes
Nov 16, 2021
Collaborator
39 tasks
Collaborator
Member
|
@JckXia I think it's still CI flakyness based on the failures, not your PR. I've resumed once more and hopefully we'll get to green. |
Member
Author
|
Thank you @mhdawson! |
Member
|
It's greeeeen :) |
Member
|
Landed in 86e976f |
mhdawson
pushed a commit
that referenced
this pull request
Nov 17, 2021
PR-URL: #40552 Refs: nodejs/node-addon-api#1089 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
|
@JckXia thanks for your patience and work on this one:) |
Member
Author
|
@mhdawson Thank you so much! :) |
This was referenced Nov 18, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40552 Refs: nodejs/node-addon-api#1089 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40552 Refs: nodejs/node-addon-api#1089 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40552 Refs: nodejs/node-addon-api#1089 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetting
last_errorstruct inside the env instance if the error code isnapi_okto make sure that the error code is consistent with any other meta data inside the struct.ref: nodejs/node-addon-api#1089